Udemy Playwright: Web Automation Testing From Zero to Hero: Difference between revisions
Jump to navigation
Jump to search
Udemy Playwright: Web Automation Testing From Zero to Hero (view source)
Revision as of 22:46, 3 June 2024
, 3 June→Date Picker Page Object
Line 990: | Line 990: | ||
}</nowiki> | }</nowiki> | ||
Notes: | |||
* I feel that the page object should not have <code>expect(...)</code> in it, IMHO these ought to be in the tests themselves, with possibly helper methods in the page object to obtain the values to assert on. | |||
* I added a little input validation to check startDayFromToday is not be after endDayFromToday | |||
* Not sure I like a few of the names used, e.g. method name <code>selectDatePickerWithRangeFromToday(...)</code> is not entirely self evident what it is, and I'd probably just want to use Date object for start and end input parameters, rather than the number of days from today. | |||
=== Page Objects Manager === | === Page Objects Manager === |